From: Michael Krufky <mkrufky@linuxtv.org>
Date: Mon, 5 Nov 2007 12:54:42 +0000 (-0300)
Subject: V4L/DVB (6563): tda8290: optimize for loop in tda829x_probe function
X-Git-Tag: v2.6.25-rc1~1235^2~394
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bbe1e0ba527a18e1ddda2eabb9da369e5bcf556e;p=linux-2.6

V4L/DVB (6563): tda8290: optimize for loop in tda829x_probe function

Thanks to Trent Piepho for pointing this out.

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

diff --git a/drivers/media/video/tda8290.c b/drivers/media/video/tda8290.c
index a849ded000..c606f3c38c 100644
--- a/drivers/media/video/tda8290.c
+++ b/drivers/media/video/tda8290.c
@@ -754,9 +754,8 @@ int tda829x_probe(struct tuner *t)
 	tuner_i2c_xfer_send(&i2c_props, soft_reset, 1);
 	tuner_i2c_xfer_recv(&i2c_props, buf, PROBE_BUFFER_SIZE);
 	for (i = 1; i < PROBE_BUFFER_SIZE; i++) {
-		if (buf[i] == buf[0])
-			continue;
-		break;
+		if (buf[i] != buf[0])
+			break;
 	}
 
 	/* all bytes are equal, not a tda829x - probably a tda9887 */