From: Eric Sesterhenn <snakebyte@gmx.de>
Date: Mon, 10 Apr 2006 23:43:03 +0000 (-0700)
Subject: [DCCP]: Fix leak in net/dccp/ipv4.c
X-Git-Tag: v2.6.17-rc2~82^2~3
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b8282dcf0417bbc8a0786c129fdff9cc768f8f3c;p=linux-2.6

[DCCP]: Fix leak in net/dccp/ipv4.c

we dont free req if we cant parse the options.
This fixes coverity bug id #1046

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c
index 29047995c6..f2c011fd2b 100644
--- a/net/dccp/ipv4.c
+++ b/net/dccp/ipv4.c
@@ -498,7 +498,7 @@ int dccp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
 		goto drop;
 
 	if (dccp_parse_options(sk, skb))
-		goto drop;
+		goto drop_and_free;
 
 	dccp_openreq_init(req, &dp, skb);