From: Prarit Bhargava Date: Thu, 9 Feb 2006 22:14:52 +0000 (-0800) Subject: [IA64-SGI] Small cleanup for misuse of list_for_each to list_for_each_safe. X-Git-Tag: v2.6.16-rc3~45^2~3 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b6bb761897d3b0225fa9d61fc4782b02bab9a6e1;p=linux-2.6 [IA64-SGI] Small cleanup for misuse of list_for_each to list_for_each_safe. Patch was suggested by Kenneth W. Chen here Signed-off-by: Prarit Bhargava Signed-off-by: Tony Luck --- diff --git a/arch/ia64/sn/kernel/io_init.c b/arch/ia64/sn/kernel/io_init.c index 2e4e56be8d..3437c23904 100644 --- a/arch/ia64/sn/kernel/io_init.c +++ b/arch/ia64/sn/kernel/io_init.c @@ -617,17 +617,15 @@ void sn_bus_store_sysdata(struct pci_dev *dev) void sn_bus_free_sysdata(void) { struct sysdata_el *element; - struct list_head *list; + struct list_head *list, *safe; -sn_sysdata_free_start: - list_for_each(list, &sn_sysdata_list) { + list_for_each_safe(list, safe, &sn_sysdata_list) { element = list_entry(list, struct sysdata_el, entry); list_del(&element->entry); list_del(&(((struct pcidev_info *) (element->sysdata))->pdi_list)); kfree(element->sysdata); kfree(element); - goto sn_sysdata_free_start; } return; }