From: Lennart Poettering <lennart@poettering.net>
Date: Sun, 3 Jul 2011 21:19:55 +0000 (+0200)
Subject: logind: write rules files atomically
X-Git-Tag: v30~57
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b5ef5549e9889eea1c66c4ed88667b5922cd9f76;p=systemd

logind: write rules files atomically
---

diff --git a/TODO b/TODO
index f494b050..3908311c 100644
--- a/TODO
+++ b/TODO
@@ -25,19 +25,14 @@ Features:
 
 * kernel: add /proc/sys file exposing CAP_LAST_CAP?
 
-* understand https://bugzilla.redhat.com/show_bug.cgi?id=672194
-
-* possibly set timezone offset from systemd at init instead
-  of calling hwclock
-
 * kernel: add device_type = "fb", "fbcon" to class "graphics"
 
+* understand https://bugzilla.redhat.com/show_bug.cgi?id=672194
+
 * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG ioctl, with START_IO
 
 * readahead: check whether a btrfs volume includes ssd by checking mount flag "ssd"
 
-* hostnamed: make file updates atomic
-
 * support sd_notify() style notificatio when reload is finished (RELOADED=1)
 
 * verify that the AF_UNIX sockets of a service in the fs still exist
diff --git a/src/logind-dbus.c b/src/logind-dbus.c
index 96216e43..95bb07a4 100644
--- a/src/logind-dbus.c
+++ b/src/logind-dbus.c
@@ -634,7 +634,7 @@ static int attach_device(Manager *m, const char *seat, const char *sysfs) {
         }
 
         mkdir_p("/etc/udev/rules.d", 0755);
-        r = write_one_line_file(file, rule);
+        r = write_one_line_file_atomic(file, rule);
         if (r < 0)
                 goto finish;