From: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Date: Mon, 12 Jun 2006 03:58:33 +0000 (-0700)
Subject: [DCCP] Ackvec: fix soft lockup in ackvec handling code
X-Git-Tag: v2.6.17~20^2~2
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=afec35e3fee900b3016519d0b5512064e4625b2c;p=linux-2.6

[DCCP] Ackvec: fix soft lockup in ackvec handling code

A soft lockup existed in the handling of ack vector records.
Specifically, when a tail of the list of ack vector records was
removed, it was possible to end up iterating infinitely on an element
of the tail.

Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/dccp/ackvec.c b/net/dccp/ackvec.c
index b5981e5f6b..8c211c5889 100644
--- a/net/dccp/ackvec.c
+++ b/net/dccp/ackvec.c
@@ -452,6 +452,7 @@ found:
 					      (unsigned long long)
 					      avr->dccpavr_ack_ackno);
 				dccp_ackvec_throw_record(av, avr);
+				break;
 			}
 			/*
 			 * If it wasn't received, continue scanning... we might