From: Joonwoo Park Date: Mon, 30 Jun 2008 19:42:23 +0000 (-0700) Subject: textsearch: fix Boyer-Moore text search bug X-Git-Tag: v2.6.26-rc9~84^2~8 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aebb6a849cfe7d89bcacaaecc20a480dfc1180e7;p=linux-2.6 textsearch: fix Boyer-Moore text search bug The current logic has a bug which cannot find matching pattern, if the pattern is matched from the first character of target string. for example: pattern=abc, string=abcdefg pattern=a, string=abcdefg Searching algorithm should return 0 for those things. Signed-off-by: Joonwoo Park Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller --- diff --git a/lib/ts_bm.c b/lib/ts_bm.c index d90822c378..4a7fce7289 100644 --- a/lib/ts_bm.c +++ b/lib/ts_bm.c @@ -63,7 +63,7 @@ static unsigned int bm_find(struct ts_config *conf, struct ts_state *state) struct ts_bm *bm = ts_config_priv(conf); unsigned int i, text_len, consumed = state->offset; const u8 *text; - int shift = bm->patlen, bs; + int shift = bm->patlen - 1, bs; for (;;) { text_len = conf->get_next_block(consumed, &text, conf, state);