From: Andrew Morton <akpm@osdl.org>
Date: Tue, 23 Jan 2007 04:40:36 +0000 (-0800)
Subject: [PATCH] SubmitChecklist update
X-Git-Tag: v2.6.20-rc6~42
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a517b9f9fe8e57437b0b9b50e279220aaf651268;p=linux-2.6

[PATCH] SubmitChecklist update

Sing the praises of `gcc -W'.  Would have prevented that blockdev direct-IO
bug.

Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/Documentation/SubmitChecklist b/Documentation/SubmitChecklist
index 2270efa101..bfbb2718a2 100644
--- a/Documentation/SubmitChecklist
+++ b/Documentation/SubmitChecklist
@@ -72,3 +72,7 @@ kernel patches.
 
     If the new code is substantial, addition of subsystem-specific fault
     injection might be appropriate.
+
+22: Newly-added code has been compiled with `gcc -W'.  This will generate
+    lots of noise, but is good for finding bugs like "warning: comparison
+    between signed and unsigned".