From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 28 Dec 2010 13:20:21 +0000 (+0100)
Subject: tmpfiles: ensure we do no follow symlinks when cleaning up dirs
X-Git-Tag: v16~37
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a247755d5221411ffe7780677b270963682dadd1;p=systemd

tmpfiles: ensure we do no follow symlinks when cleaning up dirs

Patch suggested by Miloslav Trmac.
---

diff --git a/src/tmpfiles.c b/src/tmpfiles.c
index 120236c5..1234cbf3 100644
--- a/src/tmpfiles.c
+++ b/src/tmpfiles.c
@@ -149,7 +149,7 @@ static int dir_cleanup(
                                 DIR *sub_dir;
                                 int q;
 
-                                sub_dir = xopendirat(dirfd(d), dent->d_name);
+                                sub_dir = xopendirat(dirfd(d), dent->d_name, O_NOFOLLOW);
                                 if (sub_dir == NULL) {
                                         if (errno != ENOENT) {
                                                 log_error("opendir(%s/%s) failed: %m", p, dent->d_name);
diff --git a/src/util.c b/src/util.c
index d769d609..60af4fe6 100644
--- a/src/util.c
+++ b/src/util.c
@@ -3402,8 +3402,8 @@ bool null_or_empty(struct stat *st) {
         return false;
 }
 
-DIR *xopendirat(int fd, const char *name) {
-        return fdopendir(openat(fd, name, O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC));
+DIR *xopendirat(int fd, const char *name, int flags) {
+        return fdopendir(openat(fd, name, O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC|flags));
 }
 
 int signal_from_string_try_harder(const char *s) {
diff --git a/src/util.h b/src/util.h
index 7e1eacc6..1e4eedfb 100644
--- a/src/util.h
+++ b/src/util.h
@@ -363,7 +363,7 @@ _noreturn_ void freeze(void);
 
 bool null_or_empty(struct stat *st);
 
-DIR *xopendirat(int dirfd, const char *name);
+DIR *xopendirat(int dirfd, const char *name, int flags);
 
 void dual_timestamp_serialize(FILE *f, const char *name, dual_timestamp *t);
 void dual_timestamp_deserialize(const char *value, dual_timestamp *t);