From: Karel Zak <kzak@redhat.com>
Date: Thu, 1 Oct 2009 21:47:49 +0000 (+0200)
Subject: libblkid: add blkit_[un]ref() to TODO
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a0fff7ce3507668735c94cd363a686ef833b5605;p=util-linux

libblkid: add blkit_[un]ref() to TODO

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/TODO b/TODO
index 93a59f63..27e2b322 100644
--- a/TODO
+++ b/TODO
@@ -19,11 +19,15 @@ libblkid
 
 	FSSIZE   -- filesystem size (klibc requirement)
 
-	SBOFFSET -- superblock offset; offset where SB was detected 
-                    (swapon requirement to check details from swap header)
+ - add reference counters to the binary interfaces. Currently, all chain 
+   data are allocated in blkid_probe and cannot be used independently on 
+   the probing stuff.
 
-        MAGIC    -- magic string
-	MAGICLEN -- length of magic string
+	blkid_topology tp = blkdi_probe_get_topology(pr)
+
+	blkid_ref(tp);
+	...
+	blkid_unref(tp);
 
 fdisk(s)
 --------
diff --git a/shlibs/blkid/src/partitions/partitions.c b/shlibs/blkid/src/partitions/partitions.c
index aa70df63..82861a5b 100644
--- a/shlibs/blkid/src/partitions/partitions.c
+++ b/shlibs/blkid/src/partitions/partitions.c
@@ -258,6 +258,14 @@ int blkid_probe_filter_partitions_type(blkid_probe pr, int flag, char *names[])
  * This function is independent on blkid_do_[safe,full]probe() and
  * blkid_probe_enable_partitions() calls.
  *
+ * WARNING: the returned object will be overwritten by the next
+ *          blkid_probe_get_partitions() call for the same @pr. If you want to
+ *          use more blkid_partlist objects in the same time you have to create
+ *          more blkid_probe handlers (see blkid_new_probe()).
+ *
+ * TODO:    add blkid_ref() and blkid_unref() to allows to use blkid_partlist
+ *          independently on libblkid probing stuff.
+ *
  * Returns: list of partitions, or NULL in case of error.
  */
 blkid_partlist blkid_probe_get_partitions(blkid_probe pr)
diff --git a/shlibs/blkid/src/topology/topology.c b/shlibs/blkid/src/topology/topology.c
index f4cd3219..80499005 100644
--- a/shlibs/blkid/src/topology/topology.c
+++ b/shlibs/blkid/src/topology/topology.c
@@ -108,6 +108,14 @@ int blkid_probe_enable_topology(blkid_probe pr, int enable)
  * This function is independent on blkid_do_[safe,full]probe() and
  * blkid_probe_enable_topology() calls.
  *
+ * WARNING: the returned object will be overwritten by the next
+ *          blkid_probe_get_topology() call for the same @pr. If you want to
+ *          use more blkid_tolopogy objects in the same time you have to create
+ *          more blkid_probe handlers (see blkid_new_probe()).
+ *
+ * TODO:    add blkid_ref() and blkid_unref() to allows to use blkid_topology
+ *          independently on libblkid probing stuff.
+ *
  * Returns: blkid_tolopogy, or NULL in case of error.
  */
 blkid_topology blkid_probe_get_topology(blkid_probe pr)