From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 4 Jun 2010 20:31:33 +0000 (+0200)
Subject: unit: avoid assert on daemon reload
X-Git-Tag: 0.git+20100605+dfd8ee-1~9^2^2~4^2
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a013b84b49a7d4a30196949e24ea03066e227626;p=systemd

unit: avoid assert on daemon reload
---

diff --git a/src/manager.c b/src/manager.c
index 735a1aaa..e37aa836 100644
--- a/src/manager.c
+++ b/src/manager.c
@@ -543,6 +543,8 @@ static void manager_clear_jobs_and_units(Manager *m) {
 
         assert(m);
 
+        manager_dispatch_cleanup_queue(m);
+
         while ((j = hashmap_first(m->transaction_jobs)))
                 job_free(j);
 
@@ -555,7 +557,6 @@ void manager_free(Manager *m) {
 
         assert(m);
 
-        manager_dispatch_cleanup_queue(m);
         manager_clear_jobs_and_units(m);
 
         for (c = 0; c < _UNIT_TYPE_MAX; c++)
diff --git a/src/unit.c b/src/unit.c
index c0809194..695044a7 100644
--- a/src/unit.c
+++ b/src/unit.c
@@ -319,6 +319,10 @@ void unit_free(Unit *u) {
 
         bus_unit_send_removed_signal(u);
 
+        if (u->meta.load_state != UNIT_STUB)
+                if (UNIT_VTABLE(u)->done)
+                        UNIT_VTABLE(u)->done(u);
+
         /* Detach from next 'bigger' objects */
         SET_FOREACH(t, u->meta.names, i)
                 hashmap_remove_value(u->meta.manager->units, t, u);
@@ -344,10 +348,6 @@ void unit_free(Unit *u) {
         if (u->meta.job)
                 job_free(u->meta.job);
 
-        if (u->meta.load_state != UNIT_STUB)
-                if (UNIT_VTABLE(u)->done)
-                        UNIT_VTABLE(u)->done(u);
-
         cgroup_bonding_free_list(u->meta.cgroup_bondings);
 
         for (d = 0; d < _UNIT_DEPENDENCY_MAX; d++)