From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Tue, 11 Mar 2008 07:15:30 +0000 (+0100)
Subject: [ALSA] at73c213: remove redundant private_free routine
X-Git-Tag: v2.6.26-rc1~1087^2~134
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9f2f0f7c4e997a74ff9fb8e2e2ed0daa21962e97;p=linux-2.6

[ALSA] at73c213: remove redundant private_free routine

snd_pcm_lib_preallocate_free_for_all() is called from snd_pcm_free() just
after calling the private_free routine.  So there should be no need to call
it in driver's private_free routine.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/spi/at73c213.c b/sound/spi/at73c213.c
index 1355fe0c66..aa571152f0 100644
--- a/sound/spi/at73c213.c
+++ b/sound/spi/at73c213.c
@@ -325,15 +325,6 @@ static struct snd_pcm_ops at73c213_playback_ops = {
 	.pointer	= snd_at73c213_pcm_pointer,
 };
 
-static void snd_at73c213_pcm_free(struct snd_pcm *pcm)
-{
-	struct snd_at73c213 *chip = snd_pcm_chip(pcm);
-	if (chip->pcm) {
-		snd_pcm_lib_preallocate_free_for_all(chip->pcm);
-		chip->pcm = NULL;
-	}
-}
-
 static int __devinit snd_at73c213_pcm_new(struct snd_at73c213 *chip, int device)
 {
 	struct snd_pcm *pcm;
@@ -345,7 +336,6 @@ static int __devinit snd_at73c213_pcm_new(struct snd_at73c213 *chip, int device)
 		goto out;
 
 	pcm->private_data = chip;
-	pcm->private_free = snd_at73c213_pcm_free;
 	pcm->info_flags = SNDRV_PCM_INFO_BLOCK_TRANSFER;
 	strcpy(pcm->name, "at73c213");
 	chip->pcm = pcm;