From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 14 Mar 2011 17:05:52 +0000 (+0100)
Subject: hostname: don't override the hostname with localhost if it is already set and /etc... 
X-Git-Tag: v21~88
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9bec0b1e8d4a0cf971c113fe880deba2f9feae24;p=systemd

hostname: don't override the hostname with localhost if it is already set and /etc/hostname unset
---

diff --git a/src/hostname-setup.c b/src/hostname-setup.c
index ef68d783..e9869bb4 100644
--- a/src/hostname-setup.c
+++ b/src/hostname-setup.c
@@ -174,16 +174,36 @@ int hostname_setup(void) {
                 else
                         log_warning("Failed to read configured hostname: %s", strerror(-r));
 
-                hn = "localhost";
+                hn = NULL;
         } else
                 hn = b;
 
+        if (!hn) {
+                /* Don't override the hostname if it is unset and not
+                 * explicitly configured */
+
+                char *old_hostname = NULL;
+
+                if ((old_hostname = gethostname_malloc())) {
+                        bool already_set;
+
+                        already_set = old_hostname[0] != 0;
+                        free(old_hostname);
+
+                        if (already_set)
+                                goto finish;
+                }
+
+                hn = "localhost";
+        }
+
         if (sethostname(hn, strlen(hn)) < 0) {
                 log_warning("Failed to set hostname to <%s>: %m", hn);
                 r = -errno;
         } else
                 log_info("Set hostname to <%s>.", hn);
 
+finish:
         free(b);
 
         return r;