From: Denis V. Lunev <den@openvz.org>
Date: Sat, 29 Mar 2008 01:24:01 +0000 (-0700)
Subject: [UDP]: No need to check afinfo != NULL in udp_proc_(un)register.
X-Git-Tag: v2.6.26-rc1~1138^2~275
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=997feb5e7a24ce155c1d3bea9d0b5c6530bb6197;p=linux-2.6

[UDP]: No need to check afinfo != NULL in udp_proc_(un)register.

udp_proc_register/udp_proc_unregister are called with a static pointer only.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index d695097be2..eb0c64da26 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1628,8 +1628,6 @@ int udp_proc_register(struct net *net, struct udp_seq_afinfo *afinfo)
 	struct proc_dir_entry *p;
 	int rc = 0;
 
-	if (!afinfo)
-		return -EINVAL;
 	afinfo->seq_fops->owner		= afinfo->owner;
 	afinfo->seq_fops->open		= udp_seq_open;
 	afinfo->seq_fops->read		= seq_read;
@@ -1646,8 +1644,6 @@ int udp_proc_register(struct net *net, struct udp_seq_afinfo *afinfo)
 
 void udp_proc_unregister(struct net *net, struct udp_seq_afinfo *afinfo)
 {
-	if (!afinfo)
-		return;
 	proc_net_remove(net, afinfo->name);
 	memset(afinfo->seq_fops, 0, sizeof(*afinfo->seq_fops));
 }