From: Bert Wesarg Date: Sat, 16 Apr 2005 22:25:43 +0000 (-0700) Subject: [PATCH] fix module_param_string() calls X-Git-Tag: v2.6.12-rc3~118 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=975e046cc06005bafe0c5ce81d55a1b1eb84f5a1;p=linux-2.6 [PATCH] fix module_param_string() calls This patch fix 3 calls to module_param_string() in driver/media/video/tuner-core.c and drivers/media/video/tda9887.c. In all three places, the len and the perm parameter was switched. Signed-off-by: Bert Wesarg Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/media/video/tda9887.c b/drivers/media/video/tda9887.c index d9c3169f9a..debef1910c 100644 --- a/drivers/media/video/tda9887.c +++ b/drivers/media/video/tda9887.c @@ -478,9 +478,9 @@ static int tda9887_set_pinnacle(struct tda9887 *t, char *buf) /* ---------------------------------------------------------------------- */ static char pal[] = "-"; -module_param_string(pal, pal, 0644, sizeof(pal)); +module_param_string(pal, pal, sizeof(pal), 0644); static char secam[] = "-"; -module_param_string(secam, secam, 0644, sizeof(secam)); +module_param_string(secam, secam, sizeof(secam), 0644); static int tda9887_fixup_std(struct tda9887 *t) { diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c index eded776a23..881a0539fc 100644 --- a/drivers/media/video/tuner-core.c +++ b/drivers/media/video/tuner-core.c @@ -162,7 +162,7 @@ static void set_type(struct i2c_client *c, unsigned int type) } static char pal[] = "-"; -module_param_string(pal, pal, 0644, sizeof(pal)); +module_param_string(pal, pal, sizeof(pal), 0644); static int tuner_fixup_std(struct tuner *t) {