From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 27 Jan 2010 21:40:10 +0000 (+0100)
Subject: process only one epoll event at a time
X-Git-Tag: 0.git+20100605+dfd8ee-1~384
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=957ca8908712d2a1c909472cb4581d228e89d4ad;p=systemd

process only one epoll event at a time

if we ask for more than one from the kernel we might need to check for
the validity of the ptr element since event might be processed after its
ptr was already destructed.
---

diff --git a/manager.c b/manager.c
index f15cf798..cd97e67d 100644
--- a/manager.c
+++ b/manager.c
@@ -1084,12 +1084,12 @@ int manager_loop(Manager *m) {
         assert(m);
 
         for (;;) {
-                struct epoll_event events[32];
-                int n, i;
+                struct epoll_event event;
+                int n;
 
                 manager_dispatch_run_queue(m);
 
-                if ((n = epoll_wait(m->epoll_fd, events, ELEMENTSOF(events), -1)) < 0) {
+                if ((n = epoll_wait(m->epoll_fd, &event, 1, -1)) < 0) {
 
                         if (errno == -EINTR)
                                 continue;
@@ -1097,12 +1097,12 @@ int manager_loop(Manager *m) {
                         return -errno;
                 }
 
-                for (i = 0; i < n; i++) {
-                        if ((r = process_event(m, events + i, &quit)) < 0)
-                                return r;
+                assert(n == 1);
 
-                        if (quit)
-                                return 0;
-                }
+                if ((r = process_event(m, &event, &quit)) < 0)
+                        return r;
+
+                if (quit)
+                        return 0;
         }
 }