From: Adrian Bunk <bunk@stusta.de>
Date: Mon, 30 Jul 2007 13:40:43 +0000 (+0200)
Subject: [ALSA] sound/synth/util_mem.c: remove pointless check
X-Git-Tag: v2.6.24-rc1~832^2~225
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e6c962cd3fbbd4bbde58421a07e63397c07696a;p=linux-2.6

[ALSA] sound/synth/util_mem.c: remove pointless check

The Coverity checker spotted that if anyone would call this function
with 'prev == NULL', he would still get an Oops a few lines below.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
---

diff --git a/sound/synth/util_mem.c b/sound/synth/util_mem.c
index 1d9b11f345..6fc3d2b251 100644
--- a/sound/synth/util_mem.c
+++ b/sound/synth/util_mem.c
@@ -116,7 +116,7 @@ __snd_util_memblk_new(struct snd_util_memhdr *hdr, unsigned int units,
 	if (blk == NULL)
 		return NULL;
 
-	if (! prev || prev == &hdr->block)
+	if (prev == &hdr->block)
 		blk->offset = 0;
 	else {
 		struct snd_util_memblk *p = get_memblk(prev);