From: Kay Sievers <kay.sievers@vrfy.org>
Date: Wed, 19 Aug 2009 05:31:39 +0000 (+0200)
Subject: print warning for NAME="%k" - it breaks the kernel supplied DEVNAME
X-Git-Tag: 174~822
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e2470d68ef093d39907cc67dcee377b36ba77be;p=systemd

print warning for NAME="%k" - it breaks the kernel supplied DEVNAME
---

diff --git a/udev/udev-rules.c b/udev/udev-rules.c
index 53baa187..3ca209a8 100644
--- a/udev/udev-rules.c
+++ b/udev/udev-rules.c
@@ -1406,6 +1406,9 @@ static int add_rule(struct udev_rules *rules, char *line,
 			} else {
 				if (value[0] == '\0')
 					info(rules->udev, "name empty, node creation suppressed\n");
+				else if (strcmp(value, "%k") == 0)
+					err(rules->udev, "NAME=\"%%k\" is superfluous and breaks "
+					    "kernel supplied names, please remove it from %s:%u\n", filename, lineno);
 				rule_add_key(&rule_tmp, TK_A_NAME, op, value, NULL);
 				attr = get_key_attribute(rules->udev, key + sizeof("NAME")-1);
 				if (attr != NULL) {