From: Andrew Morton <akpm@osdl.org>
Date: Tue, 7 Feb 2006 20:58:45 +0000 (-0800)
Subject: [PATCH] module: strlen_user() race fix
X-Git-Tag: v2.6.16-rc3~119
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e08b756869eeb08ace17ad64c2a8cb97b18e856;p=linux-2.6

[PATCH] module: strlen_user() race fix

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/kernel/module.c b/kernel/module.c
index e058aedf6b..5aad477ddc 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1670,6 +1670,9 @@ static struct module *load_module(void __user *umod,
 		goto free_mod;
 	}
 
+	/* Userspace could have altered the string after the strlen_user() */
+	args[arglen - 1] = '\0';
+
 	if (find_module(mod->name)) {
 		err = -EEXIST;
 		goto free_mod;