From: Eric Sesterhenn <snakebyte@gmx.de>
Date: Fri, 29 Sep 2006 09:01:32 +0000 (-0700)
Subject: [PATCH] Uninitialized variable in drivers/net/wan/syncppp.c
X-Git-Tag: v2.6.19-rc1~673
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8c6ba51bdad0de0dc2a2e2415d4dac2d0db6c1a1;p=linux-2.6

[PATCH] Uninitialized variable in drivers/net/wan/syncppp.c

For len equal to 4, we never call sppp_lcp_conf_parse_options(),
therefore rmagic does not get initialized.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Paul Fulghum <paulkf@microgate.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/drivers/net/wan/syncppp.c b/drivers/net/wan/syncppp.c
index d1173089f3..218f7b574a 100644
--- a/drivers/net/wan/syncppp.c
+++ b/drivers/net/wan/syncppp.c
@@ -469,7 +469,7 @@ static void sppp_lcp_input (struct sppp *sp, struct sk_buff *skb)
 	struct net_device *dev = sp->pp_if;
 	int len = skb->len;
 	u8 *p, opt[6];
-	u32 rmagic;
+	u32 rmagic = 0;
 
 	if (!pskb_may_pull(skb, sizeof(struct lcp_header))) {
 		if (sp->pp_flags & PP_DEBUG)