From: mbuesch@freenet.de Date: Sun, 6 Feb 2005 00:39:25 +0000 (+0100) Subject: [PATCH] trivial: fix signedness X-Git-Tag: 052~11 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=85925517e67b85c94180b1de5e2cbd6a1c67c54c;p=systemd [PATCH] trivial: fix signedness We are already using %u in the sscanf() format string. The patch replaces the int for the kernel release number with unsigned int, as we can never have negative release numbers. --- diff --git a/udev_utils.c b/udev_utils.c index 3c5344a8..364037f7 100644 --- a/udev_utils.c +++ b/udev_utils.c @@ -62,11 +62,11 @@ void udev_init_device(struct udevice *udev, const char* devpath, const char *sub strcpy(udev->group, "root"); } -int kernel_release_satisfactory(int version, int patchlevel, int sublevel) +int kernel_release_satisfactory(unsigned int version, unsigned int patchlevel, unsigned int sublevel) { - static int kversion = 0; - static int kpatchlevel; - static int ksublevel; + static unsigned int kversion = 0; + static unsigned int kpatchlevel; + static unsigned int ksublevel; if (kversion == 0) { struct utsname uts; diff --git a/udev_utils.h b/udev_utils.h index cc9dd704..5d2c9c58 100644 --- a/udev_utils.h +++ b/udev_utils.h @@ -77,7 +77,7 @@ do { \ #endif extern void udev_init_device(struct udevice *udev, const char* devpath, const char *subsystem); -extern int kernel_release_satisfactory(int version, int patchlevel, int sublevel); +extern int kernel_release_satisfactory(unsigned int version, unsigned int patchlevel, unsigned int sublevel); extern int create_path(const char *path); extern int parse_get_pair(char **orig_string, char **left, char **right); extern int file_map(const char *filename, char **buf, size_t *bufsize);