From: Al Viro <viro@ftp.linux.org.uk>
Date: Mon, 25 Sep 2006 01:54:46 +0000 (+0100)
Subject: [PATCH] wrong thing iounmapped (qla3xxx)
X-Git-Tag: v2.6.19-rc1~1248
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=855fc73bf81e8f99606d6f5914c5b7c3b079d718;p=linux-2.6

[PATCH] wrong thing iounmapped (qla3xxx)

ql3xxx_probe() does ioremap and stores result in ->mem_map_registers.
On failure exit it does iounmap() of the same thing.

OTOH, ql3xxx_remove() does iounmap() of ->mmap_virt_base which is
 (a) never assigned and
 (b) never used other than in that iounmap() call.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index c184cd80a9..1574718463 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -3508,7 +3508,7 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev)
 		qdev->workqueue = NULL;
 	}
 
-	iounmap(qdev->mmap_virt_base);
+	iounmap(qdev->mem_map_registers);
 	pci_release_regions(pdev);
 	pci_set_drvdata(pdev, NULL);
 	free_netdev(ndev);