From: helge Date: Wed, 31 Aug 2005 14:33:44 +0000 (+0000) Subject: expose radio-button-list in WOx X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=82bae03defe1b6fb232eebc4ff1fffe91fbd474d;p=sope expose radio-button-list in WOx minor WOString cleanups git-svn-id: http://svn.opengroupware.org/SOPE/trunk@1098 e4a50df8-12e2-0310-a44c-efbce7f8a7e3 --- diff --git a/sope-appserver/NGObjWeb/ChangeLog b/sope-appserver/NGObjWeb/ChangeLog index 8ee1dfa2..a2c14bbb 100644 --- a/sope-appserver/NGObjWeb/ChangeLog +++ b/sope-appserver/NGObjWeb/ChangeLog @@ -1,3 +1,13 @@ +2005-08-31 Helge Hess + + * v4.5.194 + + * DynamicElements/WOString.m: minor code cleanups + + * DynamicElements/WOxMiscElemBuilder.m: removed generation of + radio-button-matrix (which is part of WOExtensions), added generation + of WORadioButtonList () + 2005-08-27 Helge Hess * GNUmakefile.preamble: improved dependency handling (v4.5.193) diff --git a/sope-appserver/NGObjWeb/DynamicElements/WOString.m b/sope-appserver/NGObjWeb/DynamicElements/WOString.m index 25590cc6..baf90e4d 100644 --- a/sope-appserver/NGObjWeb/DynamicElements/WOString.m +++ b/sope-appserver/NGObjWeb/DynamicElements/WOString.m @@ -578,15 +578,15 @@ static WOAssociation *yesAssoc = nil; /* handling of empty and nil values */ - if (self->valueWhenEmpty) { - if (obj == nil || [obj length] == 0) { + if (self->valueWhenEmpty != nil) { + if (![obj isNotEmpty]) { NSString *s; s = [self->valueWhenEmpty stringValueInComponent:sComponent]; /* Note: the missing escaping is intentional for WO 4.5 compatibility */ if (s != nil) { - if (styleName) { + if (styleName != nil) { [_response appendContentString:@""]; @@ -599,7 +599,7 @@ static WOAssociation *yesAssoc = nil; else if (self->nilString != nil && obj == nil) { NSString *s; - if (styleName) { + if (styleName != nil) { [_response appendContentString:@""]; @@ -613,7 +613,7 @@ static WOAssociation *yesAssoc = nil; /* handling of non-empty values */ - if (styleName) { + if (styleName != nil) { [_response appendContentString:@""]; diff --git a/sope-appserver/NGObjWeb/DynamicElements/WOxMiscElemBuilder.m b/sope-appserver/NGObjWeb/DynamicElements/WOxMiscElemBuilder.m index 88c42a76..a76259cd 100644 --- a/sope-appserver/NGObjWeb/DynamicElements/WOxMiscElemBuilder.m +++ b/sope-appserver/NGObjWeb/DynamicElements/WOxMiscElemBuilder.m @@ -35,7 +35,7 @@ maps to WOPopUpButton maps to WOBrowser maps to WOBrowser - maps to WORadioButtonMatrix + maps to WORadioButtonList maps to WOCheckBoxList */ @@ -98,10 +98,10 @@ if ([tag isEqualToString:@"popup"]) return NSClassFromString(@"WOPopUpButton"); break; - + case 'r': - if ([tag isEqualToString:@"radio-button-matrix"]) - return NSClassFromString(@"WORadioButtonMatrix"); + if ([tag isEqualToString:@"radio-button-list"]) + return NSClassFromString(@"WORadioButtonList"); break; case 's': diff --git a/sope-appserver/NGObjWeb/Version b/sope-appserver/NGObjWeb/Version index a85a8f30..84816ceb 100644 --- a/sope-appserver/NGObjWeb/Version +++ b/sope-appserver/NGObjWeb/Version @@ -1,6 +1,6 @@ # version file -SUBMINOR_VERSION:=193 +SUBMINOR_VERSION:=194 # v4.5.122 requires libNGExtensions v4.5.153 # v4.5.91 requires libNGExtensions v4.5.134