From: Francois Romieu <romieu@fr.zoreil.com>
Date: Sun, 17 Dec 2006 23:00:55 +0000 (+0100)
Subject: r8169: extraneous Cmd{Tx/Rx}Enb write
X-Git-Tag: v2.6.20-rc3~56^2
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=81f4e6c190a0fa016fd7eecaf76a5f95d121afc2;p=linux-2.6

r8169: extraneous Cmd{Tx/Rx}Enb write

Checked in Realtek's driver, this one has no business being there.
The driver still works but there is a noticeable performance drop.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
---

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 148910025f..577babd4c9 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1882,7 +1882,6 @@ static void rtl8169_hw_start(struct net_device *dev)
 	    (tp->mac_version == RTL_GIGA_MAC_VER_02) ||
 	    (tp->mac_version == RTL_GIGA_MAC_VER_03) ||
 	    (tp->mac_version == RTL_GIGA_MAC_VER_04))
-		RTL_W8(ChipCmd, CmdTxEnb | CmdRxEnb);
 		rtl8169_set_rx_tx_config_registers(tp);
 
 	cmd = RTL_R16(CPlusCmd);