From: Scott Wood Date: Mon, 20 Aug 2007 16:36:59 +0000 (+1000) Subject: [POWERPC] Use strcasecmp() rather than strncasecmp() when determining device node... X-Git-Tag: v2.6.24-rc1~1450^2~319 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=804ace8881d211ac448082e871dd312132393049;p=linux-2.6 [POWERPC] Use strcasecmp() rather than strncasecmp() when determining device node compatibility The current code assumes "foo-bar" must always be compatible with a node compatible with "foo", which breaks device trees where this is not so. The "case" part is also wrong according to Open Firmware, but it's more likely to have drivers and/or device trees depending on it, and thus needs to be handled more carefully. Signed-off-by: Scott Wood Signed-off-by: Paul Mackerras --- diff --git a/include/asm-powerpc/prom.h b/include/asm-powerpc/prom.h index 920b75620f..925e2d384b 100644 --- a/include/asm-powerpc/prom.h +++ b/include/asm-powerpc/prom.h @@ -24,7 +24,7 @@ #define OF_ROOT_NODE_ADDR_CELLS_DEFAULT 1 #define OF_ROOT_NODE_SIZE_CELLS_DEFAULT 1 -#define of_compat_cmp(s1, s2, l) strncasecmp((s1), (s2), (l)) +#define of_compat_cmp(s1, s2, l) strcasecmp((s1), (s2)) #define of_prop_cmp(s1, s2) strcmp((s1), (s2)) #define of_node_cmp(s1, s2) strcasecmp((s1), (s2))