From: Ansgar Burchardt Date: Sun, 16 Sep 2012 15:46:38 +0000 (+0200) Subject: daklib/checks.py: restore comment about hijack check X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=78eb71445e77d668a2c71dceee0437a8574ae122;p=dak daklib/checks.py: restore comment about hijack check --- diff --git a/daklib/checks.py b/daklib/checks.py index fcb5a325..5be0d966 100644 --- a/daklib/checks.py +++ b/daklib/checks.py @@ -354,6 +354,10 @@ class ACLCheck(Check): """Check the uploader is allowed to upload the packages in .changes""" def _does_hijack(self, session, upload, suite): + # Try to catch hijacks. + # This doesn't work correctly. Uploads to experimental can still + # "hijack" binaries from unstable. Also one can hijack packages + # via buildds (but people who try this should not be DMs). for binary_name in upload.changes.binary_names: binaries = session.query(DBBinary).join(DBBinary.source) \ .filter(DBBinary.suites.contains(suite)) \