From: Adrian Bunk <bunk@kernel.org>
Date: Thu, 28 Feb 2008 00:21:15 +0000 (-0300)
Subject: V4L/DVB (7328): usb/opera1.c: fix a memory leak
X-Git-Tag: v2.6.25-rc7~61^2~4
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=77596058e1c2ad95b566dfdc926611a8dd820ee0;p=linux-2.6

V4L/DVB (7328): usb/opera1.c: fix a memory leak

This patch fixes a memory leak in the "testval == 0x67" case spotted by
the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

diff --git a/drivers/media/dvb/dvb-usb/opera1.c b/drivers/media/dvb/dvb-usb/opera1.c
index 21935bf705..302cc67407 100644
--- a/drivers/media/dvb/dvb-usb/opera1.c
+++ b/drivers/media/dvb/dvb-usb/opera1.c
@@ -478,9 +478,9 @@ static int opera1_xilinx_load_firmware(struct usb_device *dev,
 				err("could not restart the USB controller CPU.");
 				ret = -EINVAL;
 			}
-			kfree(p);
 		}
 	}
+	kfree(p);
 	if (fw) {
 		release_firmware(fw);
 	}