From: Greg Kroah-Hartman <gregkh@suse.de>
Date: Mon, 30 Jul 2007 18:26:38 +0000 (-0700)
Subject: modules: better error messages when modules fail to load due to a sysfs problem.
X-Git-Tag: v2.6.23-rc2~150^2
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=74c5b597e9c2fc728c61582afdea4971a5c8ed8f;p=linux-2.6

modules: better error messages when modules fail to load due to a sysfs problem.

This helps people when debugging problems like the ones that were in the
recent -mm releases.


Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/kernel/params.c b/kernel/params.c
index effbaaedd7..4e57732fcf 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -567,7 +567,12 @@ static void __init kernel_param_sysfs_setup(const char *name,
 	kobject_set_name(&mk->kobj, name);
 	kobject_init(&mk->kobj);
 	ret = kobject_add(&mk->kobj);
-	BUG_ON(ret < 0);
+	if (ret) {
+		printk(KERN_ERR "Module '%s' failed to be added to sysfs, "
+		      "error number %d\n", name, ret);
+		printk(KERN_ERR	"The system will be unstable now.\n");
+		return;
+	}
 	param_sysfs_setup(mk, kparam, num_params, name_skip);
 	kobject_uevent(&mk->kobj, KOBJ_ADD);
 }