From: Miklos Szeredi <miklos@szeredi.hu>
Date: Fri, 8 Jul 2005 00:57:29 +0000 (-0700)
Subject: [PATCH] dcookies.c: use proper refcounting functions
X-Git-Tag: v2.6.13-rc3~215
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=732dbef606f22a23cb3e1029d613977ec645e8ae;p=linux-2.6

[PATCH] dcookies.c: use proper refcounting functions

Dcookies shouldn't play with the internals of dentry and vfsmnt
refcounting.  It defeats grepping, and is prone to break if implementation
details change.

In addition the function doesn't even seem to be performance critical: it
calls kmem_cache_alloc().

Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Acked-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/fs/dcookies.c b/fs/dcookies.c
index 581aac959c..02aa0ddc58 100644
--- a/fs/dcookies.c
+++ b/fs/dcookies.c
@@ -94,12 +94,10 @@ static struct dcookie_struct * alloc_dcookie(struct dentry * dentry,
 	if (!dcs)
 		return NULL;
 
-	atomic_inc(&dentry->d_count);
-	atomic_inc(&vfsmnt->mnt_count);
 	dentry->d_cookie = dcs;
 
-	dcs->dentry = dentry;
-	dcs->vfsmnt = vfsmnt;
+	dcs->dentry = dget(dentry);
+	dcs->vfsmnt = mntget(vfsmnt);
 	hash_dcookie(dcs);
 
 	return dcs;