From: Gerrit Renker Date: Wed, 26 Sep 2007 14:26:04 +0000 (-0300) Subject: [DCCP]: Add FIXME for send_delayed_ack X-Git-Tag: v2.6.24-rc1~1454^2~353 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=727ecc5faaf6e976fc841649821c865ebd1e822d;p=linux-2.6 [DCCP]: Add FIXME for send_delayed_ack This adds a FIXME to signal that the function dccp_send_delayed_ack is nowhere used in the entire DCCP/CCID code. Using a delayed Ack timer is suggested in 11.3 of RFC 4340, but it has also rather subtle implications for the Ack-Ratio-accounting. CCID2 does not use this (maybe it should). I think leaving the function in is good, in case someone wants to implement this. Signed-off-by: Gerrit Renker Signed-off-by: Arnaldo Carvalho de Melo --- diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h index bd4645b3a3..f62eeb3749 100644 --- a/net/dccp/dccp.h +++ b/net/dccp/dccp.h @@ -209,7 +209,6 @@ extern void dccp_v4_send_check(struct sock *sk, int len, struct sk_buff *skb); extern int dccp_retransmit_skb(struct sock *sk, struct sk_buff *skb); extern void dccp_send_ack(struct sock *sk); -extern void dccp_send_delayed_ack(struct sock *sk); extern void dccp_reqsk_send_ack(struct sk_buff *sk, struct request_sock *rsk); extern void dccp_send_sync(struct sock *sk, const u64 seq, diff --git a/net/dccp/output.c b/net/dccp/output.c index 6e23d5b57e..d0c9ec6494 100644 --- a/net/dccp/output.c +++ b/net/dccp/output.c @@ -477,6 +477,7 @@ void dccp_send_ack(struct sock *sk) EXPORT_SYMBOL_GPL(dccp_send_ack); +/* FIXME: Is this still necessary (11.3) - currently nowhere used by DCCP. */ void dccp_send_delayed_ack(struct sock *sk) { struct inet_connection_sock *icsk = inet_csk(sk);