From: Jiri Slaby <jirislaby@gmail.com>
Date: Sat, 10 Feb 2007 09:45:22 +0000 (-0800)
Subject: [PATCH] Char: mxser_new, do not null driver_data
X-Git-Tag: v2.6.21-rc1~274^2~330
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=722d5e4ae89f061582cc46ccbbd3b5ae87a6e165;p=linux-2.6

[PATCH] Char: mxser_new, do not null driver_data

driver_data are initialzed to NULL from tty layer, no need to do it in the
driver.  In this case it cases oops, since driver_data may be NULL for a short
while for another closing process.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: <osv@javad.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/drivers/char/mxser_new.c b/drivers/char/mxser_new.c
index 4c805496fb..1c8e00c4ca 100644
--- a/drivers/char/mxser_new.c
+++ b/drivers/char/mxser_new.c
@@ -927,9 +927,6 @@ static int mxser_open(struct tty_struct *tty, struct file *filp)
 	struct mxser_port *info;
 	int retval, line;
 
-	/* initialize driver_data in case something fails */
-	tty->driver_data = NULL;
-
 	line = tty->index;
 	if (line == MXSER_PORTS)
 		return 0;