From: Emmanuel Rodriguez <emmanuel.rodriguez@gmail.com>
Date: Tue, 19 May 2009 10:08:15 +0000 (+0200)
Subject: Don't invoke gperl_callback_invoke() with the extra data gpointer.
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7133a29950f14d980c68ec3809395bec79d864b9;p=libchamplain

Don't invoke gperl_callback_invoke() with the extra data gpointer.

The data gpointer is used to pass the Perl callback. It makes no sense to pass
it back to the Perl callback.
---

diff --git a/bindings/perl/Champlain/xs/ChamplainMapSourceFactory.xs b/bindings/perl/Champlain/xs/ChamplainMapSourceFactory.xs
index 50dffda..3cc403e 100644
--- a/bindings/perl/Champlain/xs/ChamplainMapSourceFactory.xs
+++ b/bindings/perl/Champlain/xs/ChamplainMapSourceFactory.xs
@@ -19,8 +19,8 @@ champlainperl_constructor (ChamplainMapSourceDesc *desc, gpointer data) {
 	}
 	
 	g_value_init(&return_value, callback->return_type);
-	
-	gperl_callback_invoke(callback, &return_value, desc, data);
+	/* FIXME desc is not passed as a Champlain::MapSourceDesc to the perl callback */
+	gperl_callback_invoke(callback, &return_value, desc);
 	
 	retval = g_value_get_object (&return_value);
 	g_value_unset(&return_value);