From: Clemens Lang <neverpanic@gmail.com>
Date: Sat, 18 Feb 2012 16:44:21 +0000 (+0100)
Subject: Suggest parantheses around assgnmnt used as truth value
X-Git-Tag: v1.6.4~14
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7071877a17e2e6ece2ca8ab0cd3667f816ab89bb;p=yubikey-personalization

Suggest parantheses around assgnmnt used as truth value
---

diff --git a/ykcore/ykcore.c b/ykcore/ykcore.c
index 2ad29d2..200b585 100644
--- a/ykcore/ykcore.c
+++ b/ykcore/ykcore.c
@@ -544,7 +544,7 @@ int yk_write_to_key(YK_KEY *yk, uint8_t slot, const void *buf, int bufcount)
 		   to speed up the transfer */
 
 		for (i = 0; i < (FEATURE_RPT_SIZE - 1); i++) {
-			if (repbuf[i] = *ptr++) all_zeros = 0;
+			if ((repbuf[i] = *ptr++)) all_zeros = 0;
 		}
 		if (all_zeros && (seq > 0) && (ptr < end))
 			continue;