From: Adrian Bunk <bunk@stusta.de>
Date: Thu, 7 Dec 2006 04:37:25 +0000 (-0800)
Subject: [PATCH] ext4_ext_split(): remove dead code
X-Git-Tag: v2.6.20-rc1~145^2^2~162
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6fb50ea79cb869667adaa71ed32cc15dd73986de;p=linux-2.6

[PATCH] ext4_ext_split(): remove dead code

The Coverity checker noted that this was dead code, since in all places
above in this function, "err" is immediately checked.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 2608dce18f..1442ccbaea 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -800,9 +800,6 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode,
 	}
 
 	/* insert new index */
-	if (err)
-		goto cleanup;
-
 	err = ext4_ext_insert_index(handle, inode, path + at,
 				    le32_to_cpu(border), newblock);