From: Andrew Morton Date: Mon, 14 Apr 2008 11:09:33 +0000 (+0200) Subject: [ALSA] es1968 - fix coding style in the last patch X-Git-Tag: v2.6.26-rc1~1087^2~68 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=66c9aa6043798197e1760eaf4c5f510d6c69b95a;p=linux-2.6 [ALSA] es1968 - fix coding style in the last patch WARNING: braces {} are not necessary for single statement blocks #40: FILE: sound/pci/es1968.c:1831: + if (diff > 1) { + __maestro_write(chip, IDR0_DATA_PORT, cp1); + } total: 0 errors, 1 warnings, 35 lines checked ./patches/es1968-fix-jitter-on-some-maestro-cards.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Andreas Mueller Tested-by: Rene Herman Signed-off-by: Andrew Morton Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/es1968.c b/sound/pci/es1968.c index f8f3bb662d..1383798960 100644 --- a/sound/pci/es1968.c +++ b/sound/pci/es1968.c @@ -1840,9 +1840,8 @@ static void snd_es1968_suppress_jitter(struct es1968 *chip, struct esschan *es) cp2 = __apu_get_register(chip, 1, 5); diff = (cp1 > cp2 ? cp1 - cp2 : cp2 - cp1); - if (diff > 1) { + if (diff > 1) __maestro_write(chip, IDR0_DATA_PORT, cp1); - } } /*