From: Jeff Garzik Date: Sat, 21 Oct 2006 02:50:50 +0000 (-0700) Subject: [ATM] firestream: handle thrown error X-Git-Tag: v2.6.19-rc3~6^2~5 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=663bab6fd097c18ae0c7a7fd1b4a44558b998cdb;p=linux-2.6 [ATM] firestream: handle thrown error gcc emits the following warning: drivers/atm/firestream.c: In function ‘fs_open’: drivers/atm/firestream.c:870: warning: ‘tmc0’ may be used uninitialized in this function This indicates a real bug. We should check make_rate() return value for potential errors. Signed-off-by: Jeff Garzik Signed-off-by: Andrew Morton Signed-off-by: David S. Miller --- diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index 40ab9b65fa..697ad82f66 100644 --- a/drivers/atm/firestream.c +++ b/drivers/atm/firestream.c @@ -1002,6 +1002,10 @@ static int fs_open(struct atm_vcc *atm_vcc) r = ROUND_UP; } error = make_rate (pcr, r, &tmc0, NULL); + if (error) { + kfree(tc); + return error; + } } fs_dprintk (FS_DEBUG_OPEN, "pcr = %d.\n", pcr); }