From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 29 Apr 2008 18:45:16 +0000 (-0700)
Subject: drivers/net/tehuti: use proper capability check for raw IO access
X-Git-Tag: v2.6.26-rc1~360
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6203554207728f43cfb9fd48585cd6500da73d42;p=linux-2.6

drivers/net/tehuti: use proper capability check for raw IO access

Yeah, in practice they both mean "root", but Alan correctly points out
that anybody who gets to do raw IO space accesses should really be using
CAP_SYS_RAWIO rather than CAP_NET_ADMIN.

Pointed-out-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c
index e83b166aa6..432e837a17 100644
--- a/drivers/net/tehuti.c
+++ b/drivers/net/tehuti.c
@@ -649,7 +649,7 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)
 		DBG("%d 0x%x 0x%x\n", data[0], data[1], data[2]);
 	}
 
-	if (!capable(CAP_NET_ADMIN))
+	if (!capable(CAP_SYS_RAWIO))
 		return -EPERM;
 
 	switch (data[0]) {