From: Takashi Iwai Date: Mon, 17 Mar 2008 08:59:32 +0000 (+0100) Subject: [ALSA] usb-audio - Add a proper error check X-Git-Tag: v2.6.26-rc1~1087^2~122 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a220c868e395bc3662d13ad4c2a18769075af54;p=linux-2.6 [ALSA] usb-audio - Add a proper error check The error in check_hw_params_convention() has to be checked and handled properly. Signed-off-by: Takashi Iwai --- diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c index f48838a078..5c40c031dd 100644 --- a/sound/usb/usbaudio.c +++ b/sound/usb/usbaudio.c @@ -1762,8 +1762,10 @@ static int check_hw_params_convention(struct snd_usb_substream *subs) channels = kcalloc(MAX_MASK, sizeof(u32), GFP_KERNEL); rates = kcalloc(MAX_MASK, sizeof(u32), GFP_KERNEL); - if (!channels || !rates) + if (!channels || !rates) { + err = -ENOMEM; goto __out; + } list_for_each(p, &subs->fmt_list) { struct audioformat *f; @@ -1916,7 +1918,10 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre 1000 * MIN_PACKS_URB, /*(nrpacks * MAX_URBS) * 1000*/ UINT_MAX); - if (check_hw_params_convention(subs)) { + err = check_hw_params_convention(subs); + if (err < 0) + return err; + else if (err) { hwc_debug("setting extra hw constraints...\n"); if ((err = snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_RATE, hw_rule_rate, subs,