From: Ian Dall <ian@beware.dropbear.id.au>
Date: Wed, 13 Jul 2005 14:15:18 +0000 (-0500)
Subject: JFS: Need to be root to create files with security context
X-Git-Tag: v2.6.13-rc4~130^2
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=59192ed9e7aa81b06a1803661419f7261afca1ad;p=linux-2.6

JFS: Need to be root to create files with security context

It turns out this is due to some inverted logic in xattr.c

Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>
---

diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c
index fdd8f3f5a7..554ec739e4 100644
--- a/fs/jfs/xattr.c
+++ b/fs/jfs/xattr.c
@@ -790,12 +790,12 @@ static int can_set_xattr(struct inode *inode, const char *name,
 		 */
 		return can_set_system_xattr(inode, name, value, value_len);
 
-	if(strncmp(name, XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN) != 0)
+	if(strncmp(name, XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN) == 0)
 		return (capable(CAP_SYS_ADMIN) ? 0 : -EPERM);
 
 #ifdef CONFIG_JFS_SECURITY
 	if (strncmp(name, XATTR_SECURITY_PREFIX, XATTR_SECURITY_PREFIX_LEN)
-	    != 0)
+	    == 0)
 		return 0;	/* Leave it to the security module */
 #endif