From: Dave Peterson Date: Sun, 26 Mar 2006 09:38:51 +0000 (-0800) Subject: [PATCH] EDAC: reorder EXPORT_SYMBOL macros X-Git-Tag: v2.6.17-rc1~542 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=54933dddc3e8ccd9db48966d8ada11951cb8a558;p=linux-2.6 [PATCH] EDAC: reorder EXPORT_SYMBOL macros Fix EDAC code so EXPORT_SYMBOL comes after the function that is being exported. This is to maintain consistency with the rest of the kernel. Signed-off-by: David S. Peterson Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c index ad812a4f8c..f67a4d6f89 100644 --- a/drivers/edac/edac_mc.c +++ b/drivers/edac/edac_mc.c @@ -1199,7 +1199,6 @@ static void edac_remove_sysfs_mci_device(struct mem_ctl_info *mci) #ifdef CONFIG_EDAC_DEBUG -EXPORT_SYMBOL(edac_mc_dump_channel); void edac_mc_dump_channel(struct channel_info *chan) { @@ -1209,10 +1208,9 @@ void edac_mc_dump_channel(struct channel_info *chan) debugf4("\tchannel->label = '%s'\n", chan->label); debugf4("\tchannel->csrow = %p\n\n", chan->csrow); } +EXPORT_SYMBOL(edac_mc_dump_channel); -EXPORT_SYMBOL(edac_mc_dump_csrow); - void edac_mc_dump_csrow(struct csrow_info *csrow) { debugf4("\tcsrow = %p\n", csrow); @@ -1227,10 +1225,9 @@ void edac_mc_dump_csrow(struct csrow_info *csrow) debugf4("\tcsrow->channels = %p\n", csrow->channels); debugf4("\tcsrow->mci = %p\n\n", csrow->mci); } +EXPORT_SYMBOL(edac_mc_dump_csrow); -EXPORT_SYMBOL(edac_mc_dump_mci); - void edac_mc_dump_mci(struct mem_ctl_info *mci) { debugf3("\tmci = %p\n", mci); @@ -1245,6 +1242,7 @@ void edac_mc_dump_mci(struct mem_ctl_info *mci) mci->mod_name, mci->ctl_name); debugf3("\tpvt_info = %p\n\n", mci->pvt_info); } +EXPORT_SYMBOL(edac_mc_dump_mci); #endif /* CONFIG_EDAC_DEBUG */ @@ -1284,8 +1282,6 @@ static inline char * align_ptr (void *ptr, unsigned size) } -EXPORT_SYMBOL(edac_mc_alloc); - /** * edac_mc_alloc: Allocate a struct mem_ctl_info structure * @size_pvt: size of private storage needed @@ -1357,10 +1353,9 @@ struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned nr_csrows, return mci; } +EXPORT_SYMBOL(edac_mc_alloc); -EXPORT_SYMBOL(edac_mc_free); - /** * edac_mc_free: Free a previously allocated 'mci' structure * @mci: pointer to a struct mem_ctl_info structure @@ -1369,6 +1364,7 @@ void edac_mc_free(struct mem_ctl_info *mci) { kfree(mci); } +EXPORT_SYMBOL(edac_mc_free); static struct mem_ctl_info *find_mci_by_pdev(struct pci_dev *pdev) { @@ -1450,8 +1446,6 @@ static void del_mc_from_global_list (struct mem_ctl_info *mci) } -EXPORT_SYMBOL(edac_mc_add_mc); - /** * edac_mc_add_mc: Insert the 'mci' structure into the mci global list and * create sysfs entries associated with mci structure @@ -1509,10 +1503,9 @@ fail0: up(&mem_ctls_mutex); return 1; } +EXPORT_SYMBOL(edac_mc_add_mc); -EXPORT_SYMBOL(edac_mc_del_mc); - /** * edac_mc_del_mc: Remove sysfs entries for specified mci structure and * remove mci structure from global list @@ -1540,10 +1533,9 @@ struct mem_ctl_info * edac_mc_del_mc(struct pci_dev *pdev) mci->mod_name, mci->ctl_name, pci_name(mci->pdev)); return mci; } +EXPORT_SYMBOL(edac_mc_del_mc); -EXPORT_SYMBOL(edac_mc_scrub_block); - void edac_mc_scrub_block(unsigned long page, unsigned long offset, u32 size) { @@ -1574,11 +1566,10 @@ void edac_mc_scrub_block(unsigned long page, unsigned long offset, if (PageHighMem(pg)) local_irq_restore(flags); } +EXPORT_SYMBOL(edac_mc_scrub_block); /* FIXME - should return -1 */ -EXPORT_SYMBOL(edac_mc_find_csrow_by_page); - int edac_mc_find_csrow_by_page(struct mem_ctl_info *mci, unsigned long page) { @@ -1615,10 +1606,9 @@ int edac_mc_find_csrow_by_page(struct mem_ctl_info *mci, return row; } +EXPORT_SYMBOL(edac_mc_find_csrow_by_page); -EXPORT_SYMBOL(edac_mc_handle_ce); - /* FIXME - setable log (warning/emerg) levels */ /* FIXME - integrate with evlog: http://evlog.sourceforge.net/ */ void edac_mc_handle_ce(struct mem_ctl_info *mci, @@ -1681,10 +1671,9 @@ void edac_mc_handle_ce(struct mem_ctl_info *mci, mci->csrows[row].grain); } } +EXPORT_SYMBOL(edac_mc_handle_ce); -EXPORT_SYMBOL(edac_mc_handle_ce_no_info); - void edac_mc_handle_ce_no_info(struct mem_ctl_info *mci, const char *msg) { @@ -1694,10 +1683,9 @@ void edac_mc_handle_ce_no_info(struct mem_ctl_info *mci, mci->ce_noinfo_count++; mci->ce_count++; } +EXPORT_SYMBOL(edac_mc_handle_ce_no_info); -EXPORT_SYMBOL(edac_mc_handle_ue); - void edac_mc_handle_ue(struct mem_ctl_info *mci, unsigned long page_frame_number, unsigned long offset_in_page, int row, @@ -1750,10 +1738,9 @@ void edac_mc_handle_ue(struct mem_ctl_info *mci, mci->ue_count++; mci->csrows[row].ue_count++; } +EXPORT_SYMBOL(edac_mc_handle_ue); -EXPORT_SYMBOL(edac_mc_handle_ue_no_info); - void edac_mc_handle_ue_no_info(struct mem_ctl_info *mci, const char *msg) { @@ -1766,6 +1753,7 @@ void edac_mc_handle_ue_no_info(struct mem_ctl_info *mci, mci->ue_noinfo_count++; mci->ue_count++; } +EXPORT_SYMBOL(edac_mc_handle_ue_no_info); #ifdef CONFIG_PCI