From: helge <helge@e4a50df8-12e2-0310-a44c-efbce7f8a7e3>
Date: Wed, 22 Feb 2006 11:58:40 +0000 (+0000)
Subject: minor code cleanups
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5385856987f40804a050b417356bae58592ba82f;p=sope

minor code cleanups


git-svn-id: http://svn.opengroupware.org/SOPE/trunk@1217 e4a50df8-12e2-0310-a44c-efbce7f8a7e3
---

diff --git a/sope-appserver/NGObjWeb/ChangeLog b/sope-appserver/NGObjWeb/ChangeLog
index 0032ada7..f9acd47f 100644
--- a/sope-appserver/NGObjWeb/ChangeLog
+++ b/sope-appserver/NGObjWeb/ChangeLog
@@ -1,3 +1,8 @@
+2006-02-22  Helge Hess  <helge.hess@opengroupware.org>
+
+	* WOComponent.m, WODirectAction.m, DynamicElements/WOBrowser.m: minor
+	  code cleanups (v4.5.219)
+
 2006-01-25  Marcus Mueller  <znek@mulle-kybernetik.com>
 
 	* SoObjects/SoObject+Traversal.m: stop traversal immediately if an
diff --git a/sope-appserver/NGObjWeb/DynamicElements/WOBrowser.m b/sope-appserver/NGObjWeb/DynamicElements/WOBrowser.m
index 0900cb8c..9af481f8 100644
--- a/sope-appserver/NGObjWeb/DynamicElements/WOBrowser.m
+++ b/sope-appserver/NGObjWeb/DynamicElements/WOBrowser.m
@@ -62,8 +62,8 @@
 
 - (id)initWithName:(NSString *)_name
   associations:(NSDictionary *)_config
-  template:(WOElement *)_c {
-
+  template:(WOElement *)_c
+{
   if ((self = [super initWithName:_name associations:_config template:_c])) {
     self->list              = OWGetProperty(_config, @"list");
     self->item              = OWGetProperty(_config, @"item");
diff --git a/sope-appserver/NGObjWeb/Version b/sope-appserver/NGObjWeb/Version
index cab29a95..0803e2fa 100644
--- a/sope-appserver/NGObjWeb/Version
+++ b/sope-appserver/NGObjWeb/Version
@@ -1,6 +1,6 @@
 # version file
 
-SUBMINOR_VERSION:=218
+SUBMINOR_VERSION:=219
 
 # v4.5.214 requires libNGExtensions v4.5.179
 # v4.5.122 requires libNGExtensions v4.5.153
diff --git a/sope-appserver/NGObjWeb/WOComponent.m b/sope-appserver/NGObjWeb/WOComponent.m
index 39a115f7..e188d7a1 100644
--- a/sope-appserver/NGObjWeb/WOComponent.m
+++ b/sope-appserver/NGObjWeb/WOComponent.m
@@ -401,7 +401,7 @@ static inline id _getExtraVar(WOComponent *self, NSString *_key) {
 }
 
 - (id)existingSession {
-  if (self->session)
+  if (self->session != nil)
     return self->session;
   
   if ([[self context] hasSession])
diff --git a/sope-appserver/NGObjWeb/WODirectAction.m b/sope-appserver/NGObjWeb/WODirectAction.m
index fa159822..992b4cac 100644
--- a/sope-appserver/NGObjWeb/WODirectAction.m
+++ b/sope-appserver/NGObjWeb/WODirectAction.m
@@ -40,7 +40,7 @@
 }
 
 - (id)initWithRequest:(WORequest *)_request {
-  if ((self = [super init])) {
+  if ((self = [super init]) != nil) {
   }
   return self;
 }