From: KAMEZAWA Hiroyuki Date: Tue, 28 Mar 2006 22:50:58 +0000 (-0800) Subject: [SCSI] for_each_possible_cpu: scsi X-Git-Tag: v2.6.17-rc2~30^2~18 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=530bba6fa898318fbf111d91402d49b1c538e3cd;p=linux-2.6 [SCSI] for_each_possible_cpu: scsi for_each_cpu() actually iterates across all possible CPUs. We've had mistakes in the past where people were using for_each_cpu() where they should have been iterating across only online or present CPUs. This is inefficient and possibly buggy. We're renaming for_each_cpu() to for_each_possible_cpu() to avoid this in the future. This patch replaces for_each_cpu with for_each_possible_cpu. Signed-off-by: KAMEZAWA Hiroyuki Signed-off-by: Andrew Morton Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 6913b06231..32979fee61 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -1243,7 +1243,7 @@ static int __init init_scsi(void) if (error) goto cleanup_sysctl; - for_each_cpu(i) + for_each_possible_cpu(i) INIT_LIST_HEAD(&per_cpu(scsi_done_q, i)); printk(KERN_NOTICE "SCSI subsystem initialized\n");