From: phk <phk@d4fa192b-c00b-0410-8231-f00ffab90ce4>
Date: Fri, 26 Sep 2008 13:20:18 +0000 (+0000)
Subject: A couple of FlexeLint nits
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=51cfb4bec900786f275af7fb5c728e7b5b71d876;p=varnish

A couple of FlexeLint nits



git-svn-id: svn+ssh://projects.linpro.no/svn/varnish/trunk@3230 d4fa192b-c00b-0410-8231-f00ffab90ce4
---

diff --git a/varnish-cache/bin/varnishd/cache_panic.c b/varnish-cache/bin/varnishd/cache_panic.c
index e6ae71b8..168627e9 100644
--- a/varnish-cache/bin/varnishd/cache_panic.c
+++ b/varnish-cache/bin/varnishd/cache_panic.c
@@ -223,13 +223,13 @@ pan_sess(const struct sess *sp)
 #undef VCL_RET_MAC
 #undef VCL_RET_MAC_E
 /*lint -restore */
-		default: stp = NULL;
+		default: hand = NULL;
 	}
 	if (stp != NULL)
 		vsb_printf(vsp, "  step = %s,\n", stp);
 	else
 		vsb_printf(vsp, "  step = 0x%x,\n", sp->step);
-	if (stp != NULL)
+	if (hand != NULL)
 		vsb_printf(vsp, "  handling = %s,\n", hand);
 	else
 		vsb_printf(vsp, "  handling = 0x%x,\n", sp->handling);
@@ -320,7 +320,7 @@ pan_ic(const char *func, const char *file, int line, const char *cond, int err,
 	}
 #endif
 	if (params->diag_bitmap & 0x1000)
-		(void)exit(4);
+		exit(4);
 	else
 		abort();
 }
diff --git a/varnish-cache/bin/varnishd/storage_synth.c b/varnish-cache/bin/varnishd/storage_synth.c
index aee73786..b3c66ac0 100644
--- a/varnish-cache/bin/varnishd/storage_synth.c
+++ b/varnish-cache/bin/varnishd/storage_synth.c
@@ -89,8 +89,6 @@ SMS_Makesynth(struct object *obj)
 
 	sto = calloc(sizeof *sto, 1);
 	XXXAN(sto);
-	if (sto == NULL)
-		return (NULL);
 	vsb = vsb_newauto();
 	XXXAN(vsb);
 	sto->priv = vsb;