From: Mark Hymers <mhy@debian.org>
Date: Mon, 26 Oct 2009 18:20:43 +0000 (+0000)
Subject: Dear Ganneff, C+P coding is not helpful
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=51299d98958e1d413bebe8314f27a533db60d308;p=dak

Dear Ganneff, C+P coding is not helpful

Signed-off-by: Mark Hymers <mhy@debian.org>
---

diff --git a/dak/transitions.py b/dak/transitions.py
index a208a402..acae2072 100755
--- a/dak/transitions.py
+++ b/dak/transitions.py
@@ -406,16 +406,16 @@ def check_transitions(transitions):
         expected = t["new"]
 
         # Will be an empty list if nothing is in testing.
-        sources = get_source_in_suite(source, "testing", session)
+        sourceobj = get_source_in_suite(source, "testing", session)
 
         info[trans] = get_info(trans, source, expected, t["rm"], t["reason"], t["packages"])
         print info[trans]
 
-        if len(sources) < 1:
+        if sourceobj is None:
             # No package in testing
             print "Transition source %s not in testing, transition still ongoing." % (source)
         else:
-            current = sources[0].version
+            current = sourceobj.version
             compare = apt_pkg.VersionCompare(current, expected)
             if compare < 0:
                 # This is still valid, the current version in database is older than