From: Milan Broz <mbroz@redhat.com>
Date: Mon, 4 Sep 2006 13:37:57 +0000 (+0200)
Subject: [PATCH] fix creating zero sized bio mempools in low memory system
X-Git-Tag: v2.6.19-rc1~640^2~2
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=50be345560f1ffdcb15cc0e146416b80529a2ef2;p=linux-2.6

[PATCH] fix creating zero sized bio mempools in low memory system

In the very low memory systems is in the init_bio call
scale parameter set to zero and it leads to creating
zero sized mempool.

This patch prevents pool_entries parameter become zero,
so the created pool have at least 1 entry.

Mempool with 0 entries lead to incorrect behaviour
of mempool_free. (Alloc requests are not waken up
and system stalls in mempool_alloc->ioschedule).

Signed-off-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/fs/bio.c b/fs/bio.c
index 6a0b9ad8f8..52de79c299 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -1142,7 +1142,7 @@ static int biovec_create_pools(struct bio_set *bs, int pool_entries, int scale)
 		struct biovec_slab *bp = bvec_slabs + i;
 		mempool_t **bvp = bs->bvec_pools + i;
 
-		if (i >= scale)
+		if (pool_entries > 1 && i >= scale)
 			pool_entries >>= 1;
 
 		*bvp = mempool_create_slab_pool(pool_entries, bp->slab);