From: Yingchao Zhou <yingchao.zhou@gmail.com>
Date: Sun, 27 Aug 2006 08:23:46 +0000 (-0700)
Subject: [PATCH] Remove redundant up() in stop_machine()
X-Git-Tag: v2.6.18-rc5~18
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4edb9a143e31d2e191c199262226e1a5923ff8f7;p=linux-2.6

[PATCH] Remove redundant up() in stop_machine()

An up() is called in kernel/stop_machine.c on failure, and also in the
caller (unconditionally).

Signed-off-by: Zhou Yingchao <yingchao.zhou@gmail.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c
index dcfb5d7314..51cacd111d 100644
--- a/kernel/stop_machine.c
+++ b/kernel/stop_machine.c
@@ -111,7 +111,6 @@ static int stop_machine(void)
 	/* If some failed, kill them all. */
 	if (ret < 0) {
 		stopmachine_set_state(STOPMACHINE_EXIT);
-		up(&stopmachine_mutex);
 		return ret;
 	}