From: Kay Sievers <kay.sievers@vrfy.org>
Date: Fri, 26 Dec 2008 00:41:36 +0000 (+0100)
Subject: rules: provide /dev/raw/rawctl
X-Git-Tag: 174~1239
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=49bb7a8a2a942db5b763e5375295f81debc31ff5;p=systemd

rules: provide /dev/raw/rawctl

On Fri, Dec 26, 2008 at 01:26, Karel Zak <kzak@redhat.com> wrote:
> On Fri, Dec 26, 2008 at 12:39:16AM +0100, Kay Sievers wrote:
>> On Fri, Dec 26, 2008 at 00:26, Karel Zak <kzak@redhat.com> wrote:

>> >  The upstream raw(8) command supports /dev/rawctl and also
>> >  /dev/raw/rawctl.  I think it makes more sense to use raw/rawctl when
>> >  you have all your raw devices in raw/ subdirectory (e.g. /dev/raw/raw<N>).
>>
>> The raw tool looks for /dev/rawctl first and the fallback to
>> /dev/raw/rawctl is named DEVFS_*. Should we turn that order around and
>> remove the devfs notion from the raw tool and let udev create a
>> dev/raw/rawctl node?
>
>  Yeah. Fixed, committed and pushed.
>
>  $ strace -e open ./raw
>  open("/dev/raw/rawctl", O_RDWR)         = -1 ENOENT (No such file or directory)
>  open("/dev/rawctl", O_RDWR)             = -1 ENOENT (No such file or directory)
>
>  I have also removed the #ifdef OLD_RAW_DEVS (/dev/raw<N>) junk.
---

diff --git a/rules/rules.d/50-udev-default.rules b/rules/rules.d/50-udev-default.rules
index d6fdf00b..0eb401cd 100644
--- a/rules/rules.d/50-udev-default.rules
+++ b/rules/rules.d/50-udev-default.rules
@@ -70,7 +70,7 @@ KERNEL=="ht[0-9]*|nht[0-9]*",	GROUP="disk"
 KERNEL=="pg[0-9]*",		GROUP="disk"
 KERNEL=="pt[0-9]*|npt[0-9]*",	GROUP="disk"
 KERNEL=="qft[0-9]*|nqft[0-9]*|zqft[0-9]*|nzqft[0-9]*|rawqft[0-9]*|nrawqft[0-9]*", GROUP="disk"
-KERNEL=="rawctl",		GROUP="disk"
+KERNEL=="rawctl", NAME="raw/rawctl", GROUP="disk"
 SUBSYSTEM=="raw", KERNEL=="raw[0-9]*", NAME="raw/%k", GROUP="disk"
 KERNEL=="pktcdvd[0-9]*",	NAME="pktcdvd/%k"
 KERNEL=="pktcdvd",		NAME="pktcdvd/control"