From: Steve French Date: Wed, 18 Jan 2006 22:20:39 +0000 (-0800) Subject: [CIFS] Fix oops in cifs_readpages caused by not checking buf_type in an X-Git-Tag: v2.6.16-rc2~260^2 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=47c886b3123a335f0622136e021e7691d60d742c;p=linux-2.6 [CIFS] Fix oops in cifs_readpages caused by not checking buf_type in an error path of new cifs_readpages code. Signed-off-by: Steve French --- diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 378095a442..77c990f0cb 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -1754,7 +1754,10 @@ static int cifs_readpages(struct file *file, struct address_space *mapping, /* need to free smb_read_data buf before exit */ if (smb_read_data) { - cifs_buf_release(smb_read_data); + if(buf_type == CIFS_SMALL_BUFFER) + cifs_small_buf_release(smb_read_data); + else if(buf_type == CIFS_LARGE_BUFFER) + cifs_buf_release(smb_read_data); smb_read_data = NULL; }