From: Chris Lamb <lamby@debian.org>
Date: Thu, 29 Oct 2009 21:05:36 +0000 (+0000)
Subject: Prefer interpolation over concatenation here.
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=473d5f7657d185319a111717f4203bc4dd6defe3;p=dak

Prefer interpolation over concatenation here.

Signed-off-by: Chris Lamb <lamby@debian.org>
---

diff --git a/daklib/queue.py b/daklib/queue.py
index 9e5c16c4..edd14d7e 100755
--- a/daklib/queue.py
+++ b/daklib/queue.py
@@ -290,16 +290,13 @@ class Upload(object):
         msg = ''
 
         if len(self.rejects) > 0:
-            msg += "\n\nReject Reasons:\n"
-            msg += "\n".join(self.rejects)
+            msg += "\n\nReject Reasons:\n%s" % "\n".join(self.rejects)
 
         if len(self.warnings) > 0:
-            msg += "\n\nWarnings:\n"
-            msg += "\n".join(self.warnings)
+            msg += "\n\nWarnings:\n%s" % "\n".join(self.warnings)
 
         if len(self.notes) > 0:
-            msg += "\n\nNotes:\n"
-            msg += "\n".join(self.notes)
+            msg += "\n\nNotes:\n%s" % "\n".join(self.notes)
 
         return msg