From: Henrik Kretzschmar <henne@nachtwindheim.de>
Date: Wed, 3 Sep 2008 19:47:39 +0000 (-0300)
Subject: V4L/DVB (8682): V4L: fix return value of register video func
X-Git-Tag: v2.6.27-rc6~37^2~4^2~69
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=46f2c21cfdb1a829a9a23e23562ffa66b007dc48;p=linux-2.6

V4L/DVB (8682): V4L: fix return value of register video func

If a wrong device type is used with video_register_device_index() it should
better return an error number, instead of a constant.

Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

diff --git a/drivers/media/video/v4l2-dev.c b/drivers/media/video/v4l2-dev.c
index 6f36006aec..0320fb8411 100644
--- a/drivers/media/video/v4l2-dev.c
+++ b/drivers/media/video/v4l2-dev.c
@@ -281,7 +281,7 @@ int video_register_device_index(struct video_device *vfd, int type, int nr,
 	default:
 		printk(KERN_ERR "%s called with unknown type: %d\n",
 		       __func__, type);
-		return -1;
+		return -EINVAL;
 	}
 
 	/* pick a minor number */