From: Kay Sievers <kay.sievers@vrfy.org>
Date: Sat, 21 Jan 2012 02:07:32 +0000 (+0100)
Subject: warn about deprecated RUN+="socket:" use
X-Git-Tag: 178~2
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=430959910f1b9b67c2553f5f46c0487b0f8a3a00;p=systemd

warn about deprecated RUN+="socket:" use
---

diff --git a/src/udev-rules.c b/src/udev-rules.c
index d14a57ab..c1637128 100644
--- a/src/udev-rules.c
+++ b/src/udev-rules.c
@@ -1451,6 +1451,9 @@ static int add_rule(struct udev_rules *rules, char *line,
                 }
 
                 if (strcmp(key, "RUN") == 0) {
+                        if (strncmp(value, "socket:", 7) == 0)
+                                err(rules->udev, "RUN+=\"socket:...\" support will be removed from a future udev release. "
+                                    "Please remove it from: %s:%u and use libudev to subscribe to events.\n", filename, lineno);
                         rule_add_key(&rule_tmp, TK_A_RUN, op, value, NULL);
                         continue;
                 }
diff --git a/src/udevd.c b/src/udevd.c
index 77a1e790..17022179 100644
--- a/src/udevd.c
+++ b/src/udevd.c
@@ -230,7 +230,7 @@ static void worker_new(struct event *event)
                 sigset_t mask;
                 int rc = EXIT_SUCCESS;
 
-                /* move initial device from queue */
+                /* take initial device from queue */
                 dev = event->dev;
                 event->dev = NULL;